Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add implementation example to visualizeMouseCursor util #7292

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Jul 6, 2023

Related Issue: #N/A

Summary

Refactor to add implementation example to visualizeMouseCursor util doc.

@Elijbet Elijbet requested a review from a team as a code owner July 6, 2023 23:37
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jul 6, 2023
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elijbet Elijbet added the skip visual snapshots Pull requests that do not need visual regression testing. label Jul 6, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than using docs as the commit type instead. This looks great! Thanks for adding the example snippet.

@Elijbet Elijbet changed the title refactor: Add implementation example to visualizeMouseCursor util doc docs: Add implementation example to visualizeMouseCursor util Jul 6, 2023
@Elijbet Elijbet added docs Issues relating to documentation updates only. and removed refactor Issues tied to code that needs to be significantly reworked. labels Jul 6, 2023
@benelan benelan merged commit d591d0f into main Jul 7, 2023
@benelan benelan deleted the elijbet/refactor-visualizeMouseCursor-with-implementation-example-doc branch July 7, 2023 00:00
@github-actions github-actions bot added this to the 2023 July Priorities milestone Jul 7, 2023
benelan added a commit that referenced this pull request Jul 7, 2023
* origin/main: (22 commits)
  refactor: Ensure all setFocus methods return calls to setFocus (#7287)
  chore: release next
  fix(card): ensure teardown logic is called when disconnected (#7289)
  test: stabilize tests using setFocus (#7295)
  docs: Add implementation example to `skipAnimations` util (#7293)
  docs: Add implementation example to `visualizeMouseCursor` util (#7292)
  feat: improve focus behavior in components (#7277)
  refactor(popover): renames private method (#7286)
  build(deps): Bump focus-trap from 7.4.3 to 7.5.2 (#7279)
  chore: release next
  fix(flow): Call setFocus() on back button click (#7285)
  chore: release next
  feat(flow): Adds setFocus method (#7252)
  chore: release next
  build(deps): Bump autoprefixer from 10.4.13 to 10.4.14 (#7280)
  build(deps): Bump eslint and @types/eslint (#7282)
  fix(list): fix keyboard navigation after a listItem's disabled or closed property changes (#7275)
  fix(action): correctly focus the button after rendering updates. (#7255)
  chore: release next
  fix(tab-title): add full focus outline to closable tab button in high contrast mode (#7272)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants